linux-kernel - Re: [PATCH 01/10] x86: Change size of APICIDs from u8 to u16

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0801141908370.24893@fbirervta.pbzchgretzou.qr>
Date:	Mon, 14 Jan 2008 19:10:32 +0100 (CET)
From:	Jan Engelhardt <jengelh@...putergmbh.de>
To:	travis@....com
cc:	Andrew Morton <akpm@...ux-foundation.org>, Andi Kleen <ak@...e.de>,
	mingo@...e.hu, Christoph Lameter <clameter@....com>,
	Jack Steiner <steiner@....com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/10] x86: Change size of APICIDs from u8 to u16


On Jan 13 2008 10:34, travis@....com wrote:
>--- a/arch/x86/kernel/mpparse_64.c
>+++ b/arch/x86/kernel/mpparse_64.c
>@@ -132,7 +132,7 @@ static void __cpuinit MP_processor_info(
> 	 * area is created.
> 	 */
> 	if (x86_cpu_to_apicid_ptr) {
>-		u8 *x86_cpu_to_apicid = (u8 *)x86_cpu_to_apicid_ptr;
>+		u16 *x86_cpu_to_apicid = (u16 *)x86_cpu_to_apicid_ptr;
> 		x86_cpu_to_apicid[cpu] = m->mpc_apicid;
> 	} else {
> 		per_cpu(x86_cpu_to_apicid, cpu) = m->mpc_apicid;

You can do away with the cast while modifying this line.

>--- a/arch/x86/mm/srat_64.c
>+++ b/arch/x86/mm/srat_64.c
>@@ -384,6 +388,12 @@ int __init acpi_scan_nodes(unsigned long
> }
> 
> #ifdef CONFIG_NUMA_EMU
>+static int fake_node_to_pxm_map[MAX_NUMNODES] __initdata = {
>+	[0 ... MAX_NUMNODES-1] = PXM_INVAL
>+};
>+static unsigned char fake_apicid_to_node[MAX_LOCAL_APIC] __initdata = {
>+	[0 ... MAX_LOCAL_APIC-1] = NUMA_NO_NODE
>+};
> static int __init find_node_by_addr(unsigned long addr)
> {
> 	int ret = NUMA_NO_NODE;

No u8/u16 here?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/