linux-kernel - RE: Checkpatch.pl failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <532ABFBDAAC3A34EB12EBA6CEC2838F438AEACC7@ADPE2K703.adaptec.com>
Date:	Mon, 14 Jan 2008 11:04:40 -0800
From:	"Salyzyn, Mark" <Mark_Salyzyn@...ptec.com>
To:	"'linux-scsi@...r.kernel.org'" <linux-scsi@...r.kernel.org>
CC:	'linux-kernel' <linux-kernel@...r.kernel.org>,
	'James Bottomley' <James.Bottomley@...senPartnership.com>,
	"'jschopp@...tin.ibm.com'" <jschopp@...tin.ibm.com>,
	"'apw@...dowen.org'" <apw@...dowen.org>,
	"'rdunlap@...otime.net'" <rdunlap@...otime.net>,
	'FUJITA Tomonori' <tomof@....org>,
	"'fujita.tomonori@....ntt.co.jp'" <fujita.tomonori@....ntt.co.jp>
Subject: RE: Checkpatch.pl failure

Suppress one of the bogus checkpatch.pl error, the side-effect of the error highlighted that this constant should be replaced by an existing manifest. checkpatch.pl needs to be corrected to accept the comment style to deal with the other cases should they ever be touched by future patches. This is a tangled set of coat hangers, tug on one and never know how complicated of a mess might follow!

This attached patch is against current scsi-misc-2.6.

ObligatoryDisclaimer: Please accept my condolences regarding Outlook's handling of patch attachments, use the attachment, not the inline patch.

Signed-off-by: Mark Salyzyn <aacraid@...ptec.com>

 drivers/scsi/dpt_i2o.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -ru a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
--- a/drivers/scsi/dpt_i2o.c    2008-01-14 13:39:11.086600955 -0500
+++ b/drivers/scsi/dpt_i2o.c    2008-01-14 13:41:44.813246497 -0500
@@ -2296,7 +2296,7 @@

                // copy over the request sense data if it was a check
                // condition status
-               if (dev_status == 0x02 /*CHECK_CONDITION*/) {
+               if (dev_status == SAM_STAT_CHECK_CONDITION) {
                        u32 len = min(SCSI_SENSE_BUFFERSIZE, 40);
                        // Copy over the sense data
                        memcpy_fromio(cmd->sense_buffer, (reply+28) , len);

This geek joke brought to you by -- Mark Salyzyn

> -----Original Message-----
> From: linux-kernel-owner@...r.kernel.org
> [mailto:linux-kernel-owner@...r.kernel.org] On Behalf Of
> James Bottomley
> Sent: Monday, January 14, 2008 10:49 AM
> To: rdunlap@...otime.net; apw@...dowen.org; jschopp@...tin.ibm.com
> Cc: linux-kernel
> Subject: Checkpatch.pl failure
>
> This error:
>
> ERROR: no space before that close parenthesis ')'
> #501: FILE: drivers/scsi/dpt_i2o.c:2299:
> +               if (dev_status == 0x02 /*CHECK_CONDITION*/) {
>
> Is definitely wrong.  I think it's stripped the comments so now the if
> looks to have a space before the bracket, but stylistically the
> complaint it has errored out for is wrong.
>
> James

Download attachment "dpt_i2o_CHECK_CONDITION.patch" of type "application/octet-stream" (525 bytes)