linux-kernel - [PATCH 2/2] checkstack: fix perl warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20080114111934.0460c736@deepthought>
Date:	Mon, 14 Jan 2008 11:19:34 -0800
From:	Stephen Hemminger <stephen.hemminger@...tta.com>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH 2/2] checkstack: fix perl warnings

If you enable perl warnings on this script, it shows a couple of problems:
	
  Parentheses missing around "my" list at scripts/checkstack.pl line 105.
  Useless use of a variable in void context at scripts/checkstack.pl line 105.
  Use of uninitialized value in string eq at scripts/checkstack.pl line 33.

Signed-off-by: Stephen Hemminger <stephen.hemminger@...tta.com>

--- a/scripts/checkstack.pl	2008-01-14 11:10:57.000000000 -0800
+++ b/scripts/checkstack.pl	2008-01-14 11:11:56.000000000 -0800
@@ -30,7 +30,7 @@
 my (@stack, $re, $x, $xs);
 {
 	my $arch = shift;
-	if ($arch eq "") {
+	if (! defined $arch) {
 		$arch = `uname -m`;
 		chomp $arch;
 	}
@@ -102,7 +102,8 @@ sub bysize($) {
 #
 my $funcre = qr/^$x* <(.*)>:$/;
 my $func;
-my $file, $lastslash;
+my $file;
+my $lastslash;
 
 while (my $line = <STDIN>) {
 	if ($line =~ m/$funcre/) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/