linux-kernel - libata-scsi.c: new check-after-use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080114210805.GH9847@does.not.exist>
Date:	Mon, 14 Jan 2008 23:08:05 +0200
From:	Adrian Bunk <bunk@...nel.org>
To:	Ondrej Zary <linux@...nbow-software.org>,
	Tejun Heo <htejun@...il.com>, Jeff Garzik <jgarzik@...hat.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: libata-scsi.c: new check-after-use


Commit 9b8e8de7e59b3a2dab3113d620b52dc8ba890fb3 did:

--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -872,7 +872,8 @@ int ata_scsi_slave_config(struct scsi_device *sdev)
 
 	ata_scsi_sdev_config(sdev);
 
-	sdev->manage_start_stop = 1;
+	if (dev->class == ATA_DEV_ATA)
+		sdev->manage_start_stop = 1;
 
 	if (dev)
 		ata_scsi_dev_config(sdev, dev);


The Coverity checker spotted that this introduced a check-after-use
for "dev".


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/