linux-kernel - Re: [PATCH 08/10] x86: Change NR_CPUS arrays in numa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <p73wsqbl5pn.fsf@bingen.suse.de>
Date:	Tue, 15 Jan 2008 11:54:12 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	travis@....com
Cc:	Andrew Morton <akpm@...ux-foundation.org>, mingo@...e.hu,
	Christoph Lameter <clameter@....com>,
	Jack Steiner <steiner@....com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/10] x86: Change NR_CPUS arrays in numa_64 V2

travis@....com writes:
> +
>  /* Returns the number of the node containing CPU 'cpu' */
>  static inline int cpu_to_node(int cpu)
>  {
> -	return cpu_to_node_map[cpu];
> +	u16 *cpu_to_node_map = x86_cpu_to_node_map_early_ptr;
> +
> +	if (cpu_to_node_map)
> +		return cpu_to_node_map[cpu];
> +	else if(per_cpu_offset(cpu))
> +		return per_cpu(x86_cpu_to_node_map, cpu);
> +	else
> +		return NUMA_NO_NODE;

Seems a little big now to be still inlined.

Also I wonder if there are really that many early callers that it
isn't feasible to just convert them to a early_cpu_to_node(). Also
early_cpu_to_node() should really not be speed critical, so just
linearly searching some other table instead of setting up an explicit
array should be fine for that.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/