linux-kernel - Re: hrtimer.c devinit vs. cpuinit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080115122208.GA17122@uranus.ravnborg.org>
Date:	Tue, 15 Jan 2008 13:22:08 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: Re: hrtimer.c devinit vs. cpuinit

On Tue, Jan 15, 2008 at 01:30:10AM +0100, Johannes Berg wrote:
> Hi,
> 
> Looking through hrtimer.c I noticed
> 
> static void __devinit init_hrtimers_cpu(int cpu)
> 
> static int __cpuinit hrtimer_cpu_notify(struct notifier_block *self,
>                                         unsigned long action, void *hcpu)
> 
> 
> Couldn't the first be __cpuinit as well?

As the only user of init_hrtimers_cpu is __cpuinit then it is a bug
that init_hrtimers_cpu is __devinit today.

So you are correct and it must be fixed.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/