[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <87zlv7fdm7.fsf@saeurebad.de>
Date: Tue, 15 Jan 2008 14:00:00 +0100
From: Johannes Weiner <hannes@...urebad.de>
To: Andi Kleen <ak@...e.de>
Cc: linux-kernel@...r.kernel.org, jbeulich@...ell.com, mingo@...e.hu,
tglx@...utronix.de
Subject: Re: [PATCH] [4/31] Add pte_pgprot on i386
Hi,
Andi Kleen <ak@...e.de> writes:
[...]
> --- linux.orig/include/asm-x86/pgtable-2level.h
> +++ linux/include/asm-x86/pgtable-2level.h
> @@ -75,6 +75,8 @@ static inline int pte_exec_kernel(pte_t
> #define pgoff_to_pte(off) \
> ((pte_t) { .pte_low = (((off) & 0x1f) << 1) + (((off) >> 5) << 8) + _PAGE_FILE })
>
> +#define pte_pgprot(x) __pgprot((x).pte_low & 0xfff)
[...]
> --- linux.orig/include/asm-x86/pgtable-3level.h
> +++ linux/include/asm-x86/pgtable-3level.h
> @@ -142,6 +142,8 @@ static inline unsigned long pte_pfn(pte_
> return pte_val(pte) >> PAGE_SHIFT;
> }
>
> +#define pte_pgprot(x) __pgprot(pte_val(x) & (0xfff | _PAGE_NX))
Could we use pte_val() in both cases?
Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists