linux-kernel - Re: [PATCH] x86_64: checking aperture report for node instead of cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080115132253.GC7025@elte.hu>
Date:	Tue, 15 Jan 2008 14:22:53 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <Yinghai.Lu@....COM>
Cc:	Andi Kleen <ak@...e.de>, Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Christoph Lameter <clameter@....com>, ebiederm@...ssion.com,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86_64: checking aperture report for node instead of
	cpu


* Yinghai Lu <Yinghai.Lu@....COM> wrote:

> -		printk(KERN_INFO "CPU %d: aperture @ %Lx size %u MB\n",
> -				num-24, aper_base, aper_size>>20);
> +		printk(KERN_INFO "Node %d: aperture @ %Lx size %u MB\n",
> +				node++, aper_base, aper_size >> 20);

please dont put side-effects into printks. (put the node++ iteration out 
into a separate line) Your patch looks fine otherwise.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/