linux-kernel - Re: [PATCH] x86: move warning message of polling idle and HT enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080115132607.GE7025@elte.hu>
Date:	Tue, 15 Jan 2008 14:26:07 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
Cc:	tglx@...utronix.de, hpa@...or.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: move warning message of polling idle and HT
	enabled


* Hiroshi Shimamoto <h-shimamoto@...jp.nec.com> wrote:

> From: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
> Subject: [PATCH] x86: move warning message of polling idle and HT enabled
> 
> This warning at idle_setup() is never shown because smp_num_sibling hasn't
> been updated at this point yet.
> 
> Move this polling idle and HT enabled warning message to 
> select_idle_routine(). I also implement this warning on 64-bit kernel 
> and make select_idle_routine() call after detect_ht() call.

looks good to me, but could you please split this up into two patches 
instead - one that just moves/adds the printks, the other one that moves 
the select_idle_routine() call? (Moving init calls around is notoriously 
error-prone, so we want as small of a bisection target as possible.) 
Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/