[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080115140516.GB32567@Krystal>
Date: Tue, 15 Jan 2008 09:05:16 -0500
From: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
To: Adrian Bunk <adrian.bunk@...ial.fi>
Cc: Russell King <rmk+lkml@....linux.org.uk>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Randy Dunlap <randy.dunlap@...cle.com>, phil.el@...adoo.fr,
oprofile-list@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: Fwd: Re: [2.6.24 patch] restore ARMv6 OProfile support
* Adrian Bunk (adrian.bunk@...ial.fi) wrote:
> On Tue, Jan 15, 2008 at 10:45:26AM +0000, Russell King wrote:
> > I never got a response on my message, but I have just receieved:
> >
> > | Date: Tue, 15 Jan 2008 11:05:00 +0100
> > | From: Joerg Wagner <wagner@...neclab.eu>
> > | To: ARM Linux Mailing List <linux-arm-kernel@...ts.arm.linux.org.uk>
> > | Subject: 2.6.24-rc7 : oprofile on MPCore broken
> > |
> > | Hello,
> > |
> > | just tried to use oprofile on 2.6.24-rc7.
> > | It does not detect the right processor
> > | (/dev/oprofile/cpu_type contains "timer").
> > |
> > | As I don't know exactly, how the string
> > | "arm/mpcore" from arch/arm/oprofile/op_model_mpcore.c
> > | gets feeded into that file, maybe someone else can help ?
> >
> > So people are hitting the resulting mess created by 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9.
> > Can we please fix this regression one way or another please?
> >
> > I don't particularly like stuffing the options into some random place
> > in the architectures Kconfig file when they should stay along side the
> > instrumentation configuration entries.
>
> Below is the patch I already sent on 28 Dec 2007 that stuffs it into
> Kconfig.instrumentation.
>
> Technically it shouldn't make any difference whether this patch or
> Mathieu's patch that stuffs it into arch/arm/Kconfig gets applied, but
> one of them should be applied for 2.6.24 (plus either mine or Mathieu's
> fix for the blackfin HARDWARE_PM support broken by the same commit).
>
> I found the bugs in Mathieu's commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9,
> I wrote patches that restore the status quo, Cc'ed all people even
> remotely related to this issue, and I opened the Bugzilla bugs required
> for getting them on the regression lists. Mathieu wants the regressions
> he introduced fixed different from what my patches did and that's not a
> problem for me (his patches are also OK).
>
> What went wrong that his regression fixes did not land in Linus' tree?
>
Yes Adrian, and I thank you very much for all this work. I only
suggested the alternative patches so it would remove menu options nobody
really needs (historical special-cases) and make it easier to apply the
following set of patches already in -mm.
One way or another, either your or my arm and blackfin patches should
get into 2.6.24 final.
Mathieu
> cu
> Adrian
>
>
> <-- snip -->
>
>
> This patch restores the ARMv6 OProfile support that was killed by
> commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9.
>
> Signed-off-by: Adrian Bunk <adrian.bunk@...ial.fi>
>
> ---
>
> kernel/Kconfig.instrumentation | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> 7fc221ef169610b5eac98e2ddd641811c0d53e4a
> diff --git a/kernel/Kconfig.instrumentation b/kernel/Kconfig.instrumentation
> index 468f47a..4453187 100644
> --- a/kernel/Kconfig.instrumentation
> +++ b/kernel/Kconfig.instrumentation
> @@ -29,2 +29,17 @@ config OPROFILE
>
> +config OPROFILE_ARMV6
> + bool
> + depends on OPROFILE && ARM && CPU_V6 && !SMP
> + default y
> + select OPROFILE_ARM11_CORE
> +
> +config OPROFILE_MPCORE
> + bool
> + depends on OPROFILE && ARM && CPU_V6 && SMP
> + default y
> + select OPROFILE_ARM11_CORE
> +
> +config OPROFILE_ARM11_CORE
> + bool
> +
> config KPROBES
--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists