linux-kernel - Re: [PATCH] CRIS v10: vmlinux.lds.S Fix kernel oops on boot and use common defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080115142300.GE3912@axis.com>
Date:	Tue, 15 Jan 2008 15:23:00 +0100
From:	Jesper Nilsson <jesper.nilsson@...s.com>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Mikael Starvik <mikael.starvik@...s.com>,
	linux-kernel@...r.kernel.org, Yuusei KUWANA <kuwana@...nyan.to>
Subject: Re: [PATCH] CRIS v10: vmlinux.lds.S Fix kernel oops on boot and use common defines

On Tue, Jan 15, 2008 at 02:54:19PM +0100, Sam Ravnborg wrote:
> On Tue, Jan 15, 2008 at 02:36:24PM +0100, Jesper Nilsson wrote:
> > - Move alignment to page size of init data outside ifdef for BLK_DEV_INITRD.
> >   The reservation up to page size of memory after init data was previously
> >   not done if BLK_DEV_INITRD was undefined.
> >   This caused a kernel oops when init memory pages were freed after startup,
> >   data placed in the same page as the last init memory would also be freed
> >   and reused, with disastrous results.
> > 
> > - Use macros for initcalls and .text sections.
> > 
> > - Replace hardcoded page size constant with PAGE_SIZE define.
> > 
> > - Change include/asm-cris/page.h to use the _AC macro to instead
> >   of testing __ASSEMBLY__.
> 
> Looks good.

Thanks.

> What about applying the same fixes/changes to v32?

In the works.

> It would btw. be nice to move the vmlinux.lds.S files to
> arch/cris/kernel/.
> Se how x86 handle build for two different bit sizes.
> 
> If this is done then cris is less awkward compared
> to the other archs.

That's a really good idea. I'll add that to my todo-list.

> 	Sam

/^JN - Jesper Nilsson
--
               Jesper Nilsson -- jesper.nilsson@...s.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/