linux-kernel - Re: [PATCH 2/3] x86_64: check MSR to get MMCONFIG for AMD Family 10h Opteron

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Jan 2008 10:42:37 -0500
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Yinghai Lu <Yinghai.Lu@....COM>
CC:	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <ak@...e.de>, Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] x86_64: check MSR to get MMCONFIG for AMD Family
 10h Opteron

Yinghai Lu wrote:
> +
> +	address = 0xc0010058;
> +	if (rdmsr_safe(address, &low, &high))
> +		return NULL;
> +

NAK.  Add the symbolic MSR name to asm-x86/msr-index.h and use the 
symbolic name in the code, please.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/