linux-kernel - Re: [RFC][PATCH 4/5] memory_pressure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Jan 2008 11:37:48 +0900
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Cc:	kosaki.motohiro@...fujitsu.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, Marcelo Tosatti <marcelo@...ck.org>,
	Daniel Spang <daniel.spang@...il.com>,
	Rik van Riel <riel@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [RFC][PATCH 4/5] memory_pressure_notify() caller

Hi KAME, 

> > +	notify_threshold = (zone->pages_high +
> > +			    zone->lowmem_reserve[MAX_NR_ZONES-1]) * 2;
> > +
> Why MAX_NR_ZONES-1 ?

this is intent to max lowmem_reserve.

in normal case, 
shrink_active_list isn't called when free_pages > pages_high.
but just after memory freed, it happened rarely.

I don't want incorrect notify at system enough free memory.

related discussion
  http://marc.info/?l=linux-mm&m=119878630211348&w=2


> > +	if (unlikely((prev_free <= notify_threshold) &&
> > +		     (zone_page_state(zone, NR_FREE_PAGES) > notify_threshold)))
> > +		memory_pressure_notify(zone, 0);
> >  }
> 
> How about this
> ==
> if (unlikely(zone->mem_notify_status && ...) 

Nice idea.
I will applied it at next post.

thank you!




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/