linux-kernel - Re: HPET timer broken using 2.6.23.13 / nanosleep() hangs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.0.99999.0801161618380.3764@localhost.localdomain>
Date:	Wed, 16 Jan 2008 16:21:28 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Dhaval Giani <dhaval@...ux.vnet.ibm.com>
cc:	Andrew Paprocki <andrew@...iboo.com>, linux-kernel@...r.kernel.org,
	Balaji Rao <balajirrao@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>, clemens@...isch.de,
	venkatesh.pallipadi@...el.com, bob.picco@...com
Subject: Re: HPET timer broken using 2.6.23.13 / nanosleep() hangs

On Wed, 16 Jan 2008, Thomas Gleixner wrote:

> On Wed, 16 Jan 2008, Thomas Gleixner wrote:
> 
> > On Sun, 13 Jan 2008, Dhaval Giani wrote:
> > > On Sun, Jan 13, 2008 at 08:10:46AM -0500, Andrew Paprocki wrote:
> > > > I applied the patch to my 2.6.23.13 tree and upon reboot it stopped right after:
> > > > 
> > > > Clocksource tsc unstable (delta = ... ns)
> > > > Time: hpet clocksource has been installed.
> > > > 
> > > > It locked up hard.. cursor stopped blinking and SysRq isn't working either.
> > 
> > The hint is in the original report:
> > 
> > Clocksource tsc unstable (delta = 500013666 ns)
> > 
> > That means, that the TSC was counting, but HPET not. So it looks like
> > the HPET readout is stale. Which explains, why after switching to HPET
> > clocksource the time system gets hosed.
> > 
> > I wonder why the HPET counter works check did not catch this.
> > 
> > Can you please apply the path below and provide the output ?

This time against 2.6.23

Thanks,
	tglx


--- a/arch/i386/kernel/hpet.c
+++ b/arch/i386/kernel/hpet.c
@@ -233,7 +233,7 @@ int __init hpet_enable(void)
 	unsigned long id;
 	uint64_t hpet_freq;
 	u64 tmp, start, now;
-	cycle_t t1;
+	cycle_t t1, t2;
 
 	if (!is_hpet_capable())
 		return 0;
@@ -295,12 +295,17 @@ int __init hpet_enable(void)
 		rdtscll(now);
 	} while ((now - start) < 200000UL);
 
-	if (t1 == read_hpet()) {
+	t2 = read_hpet();
+	if (t1 == t2) {
 		printk(KERN_WARNING
 		       "HPET counter not counting. HPET disabled\n");
 		goto out_nohpet;
 	}
 
+	printk(KERN_INFO "HPET check: t1=%llu t2=%llu s=%llu n=%llu\n",
+	       (unsigned long long) t1, (unsigned long long) t2,
+	       (unsigned long long) start, (unsigned long long) now);
+
 	/* Initialize and register HPET clocksource
 	 *
 	 * hpet period is in femto seconds per cycle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/