linux-kernel - Re: [PATCH] x86: add is_f00f_bug helper to fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <478D786F.2040505@zytor.com>
Date:	Tue, 15 Jan 2008 22:22:23 -0500
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Kyle McMartin <kyle@...artin.ca>
CC:	Harvey Harrison <harvey.harrison@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] x86: add is_f00f_bug helper to fault_32|64.c

Kyle McMartin wrote:
> On Tue, Jan 15, 2008 at 06:48:35PM -0800, Harvey Harrison wrote:
>> +#ifdef CONFIG_X86_F00F_BUG
>> +void do_invalid_op(struct pt_regs *, unsigned long);
>> +#endif
>> +
>> +static int is_f00f_bug(struct pt_regs *regs, unsigned long address)
>> +{
>> +#ifdef CONFIG_X86_F00F_BUG
>> +	unsigned long nr;
> 
> You can just put the prototype inside the function, you know...

You can also make the prototype unconditional, even if the function 
doesn't necessarily exist.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/