linux-kernel - Re: [PATCH/RFCv2] wdt: Add support for PowerQUICC watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <A00FB5AE-903B-461A-B234-4BA817B3C5CB@kernel.crashing.org>
Date:	Thu, 17 Jan 2008 08:31:26 -0600
From:	Kumar Gala <galak@...nel.crashing.org>
To:	Jochen Friedrich <jochen@...am.de>
Cc:	wim@...ana.be, Scott Wood <scottwood@...escale.com>,
	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH/RFCv2] wdt: Add support for PowerQUICC watchdog


On Jan 17, 2008, at 6:47 AM, Jochen Friedrich wrote:

> The PowerQUICC series has a watchdog which can be activated by the  
> boot
> loader and then needs to be reset in regular intervals. Once the
> watchdog is enabled, it can't be disabled anymore. This patch adds
> support for this kind of watchdog. An early init function is  
> provided to
> manually reset the watchdog in early board setup. Later, a kernel  
> timer
> is used to reset the watchdog until the watchdog driver is opened from
> user space. This replaces mpc8xx_wdt.c (only usable for ARCH=ppc) and
> mpc83xx_wdt.c (untested on this platform).

Why are you commenting on mpc83xx_wdt with respect to pq1_wdt?

Also, is this driver just for PQ1 platforms or PQ1 & PQ2?  If its just  
pq1 we should probably call it pq1_wdt*

> Signed-off-by: Jochen Friedrich <jochen@...am.de>
> ---
> arch/powerpc/platforms/8xx/mpc86xads_setup.c |    5 +
> arch/powerpc/platforms/8xx/mpc885ads_setup.c |    5 +
> arch/powerpc/sysdev/Makefile                 |    3 +
> arch/powerpc/sysdev/pq_wdt.c                 |  203 +++++++++++++++++ 
> ++++++
> arch/powerpc/sysdev/pq_wdt.h                 |   28 ++++
> drivers/watchdog/Kconfig                     |   13 ++-
> drivers/watchdog/Makefile                    |    1 +
> drivers/watchdog/pq_wdt.c                    |  225 +++++++++++++++++ 
> +++++++++
> 8 files changed, 482 insertions(+), 1 deletions(-)
> create mode 100644 arch/powerpc/sysdev/pq_wdt.c
> create mode 100644 arch/powerpc/sysdev/pq_wdt.h
> create mode 100644 drivers/watchdog/pq_wdt.c

What are the bits in sysdev/pq_wdt.{c,h}.  Why aren't these just in  
drivers/watchdog?

- k
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/