linux-kernel - Re: [PATCH] x86: copy srat table and unmap in acpi_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080117220638.GA18883@elte.hu>
Date:	Thu, 17 Jan 2008 23:06:38 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <Yinghai.Lu@....COM>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: copy srat table and unmap in acpi_parse_table


* Yinghai Lu <Yinghai.Lu@....COM> wrote:

> > Or if d8d28f25f33c6a03 really needs to be reverted to get your 
> > system to boot properly, which particular bit of it was causing 
> > trouble for you? (or the whole thing?)
> 
> we need to call acpi_os_unmap_memory in acpi_table_parse or just after 
> it.
> 
> call it in acpi_table_parse is much cleaner

agreed - i had a second look at your patch and it's much cleaner.

> the problem is that acpi_numa_slit_init do bad assumaption that it 
> still can use address after it's callback function. so we need to copy 
> the slit.

ok. I've applied your patch and boot-tested it already - it should show 
up soon in the next x86.git drop.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/