linux-kernel - Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker.c compiling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0801172342230.18447@fbirervta.pbzchgretzou.qr>
Date:	Thu, 17 Jan 2008 23:44:13 +0100 (CET)
From:	Jan Engelhardt <jengelh@...putergmbh.de>
To:	Michael Opdenacker <michael-lists@...e-electrons.com>
cc:	Matt Mackall <mpm@...enic.com>, linux-kernel@...r.kernel.org,
	Linux-tiny@...enic.com, Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker.c
 compiling


On Jan 17 2008 18:05, Michael Opdenacker wrote:
>>> +ifeq ($(CONFIG_INPUT_PCSPKR),y)
>>> +	obj-y			+= pcspeaker.o
>>> +endif
>>>     
>>
>> I'm not sure this does what you want. What if CONFIG_INPUT_PCSPKR = m?
>>   
>Does it make sense to compile arch/x86/kernel/pcspeaker.c as a module?

Hardly. No. Absolutely not. pcspeaker.c is a mere 20 lines - when
compiled (on x86_64) a mere 1824 bytes (and most of that is probably
ELF overhead). If you build that as a module, be sure to add an extra
6 to 7 kilobyte as module overhead. No, this is not really worth it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/