linux-kernel - Re: [PATCH] x86: Use v8086_mode helper, trivial unification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47901E89.4060001@zytor.com>
Date:	Thu, 17 Jan 2008 22:35:37 -0500
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Harvey Harrison <harvey.harrison@...il.com>
CC:	Roland McGrath <roland@...hat.com>, Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] x86: Use v8086_mode helper, trivial unification

Harvey Harrison wrote:
> 
> What do you think of:
> 
> /*
>  * (unsigned long)regs looks strange, but it's correct for x86_32.  x86_32 CPUs
>  * don't save the ss and esp registers if the CPU is already in kernel mode
>  * when it traps.  So &regs happens to be esp.  Valid only for kernel-mode
>  * pt_regs.
>  */
> static inline unsigned long stack_pointer(struct pt_regs *regs)
> {
> #ifdef CONFIG_X86_32
> 	return (unsigned long)regs;
> #else
> 	return regs->sp;
> #endif
> }
> 

Please highlight the last sentence better.  That's a user restriction 
and a highly important one.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/