[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080118083610.GA19792@elte.hu>
Date: Fri, 18 Jan 2008 09:36:10 +0100
From: Ingo Molnar <mingo@...e.hu>
To: "Rafael J. Wysocki" <rjw@...k.pl>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Zan Lynx <zlynx@....org>, Thomas Gleixner <tglx@...utronix.de>,
Len Brown <lenb@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: echo mem > /sys/power/state
* Rafael J. Wysocki <rjw@...k.pl> wrote:
> > Probably it would be more efficient to have the people who wrote the
> > code also test it.
>
> Well, that would certainly help.
>
> I do test all of my patches and generally all of the patches I sign
> off, but surely that's not enough.
please add a .config option dependent on CONFIG_DEBUG_KERNEL=y [and
default-disabled] that auto-tests suspend/resume functionality 60
seconds after hitting user-space (the suspend/resume cycle kept small
via a small RTC timeout) and s2ram correctness will be tested _a lot_
more.
(it doesnt matter if graphics does not resume fine - at least for my
tests)
kprobes had similar problems and it now has a few simple smoke-tests -
which i just saw trigger on a patch that i did not notice would break
kprobes. I think this should be done for all functionality that is not
regularly triggered by a normal distro bootup (and which is easy to
overlook in testing).
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists