| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 18 Jan 2008 12:04:55 +0100 (CET) From: Jiri Kosina <jikos@...os.cz> To: Steven Rostedt <rostedt@...dmis.org> cc: LKML <linux-kernel@...r.kernel.org>, Linus Torvalds <torvalds@...ux-foundation.org>, Andrew Morton <akpm@...ux-foundation.org>, Alexey Dobriyan <adobriyan@...nvz.org>, Kirill Korotaev <dev@...ru> Subject: Re: [PATCH] printk deadlocks if called with runqueue lock held On Thu, 17 Jan 2008, Steven Rostedt wrote: > Thinking that it was locking up on my code I went looking down the wrong > path. I finally found (after examining an NMI dump) that the lockup > happened because printk was trying to wakeup the klogd daemon, which > caused a deadlock when the try_to_wakeup code tries to grab the runqueue > lock. ... which I have documented in the printk() comment's in commit 1492192b :) > Since printks are seldom called with interrupts disabled, we can > hold off the waking of klogd if they are. We don't have access to > the runqueue locks from printk, but those locks need interrupts > disabled in order to be held. If this patch is going to be merged, you should perhaps adjust the comment introduced by the above mentioned commit, so that it reflects the new behavior. Thanks, -- Jiri Kosina -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists