linux-kernel - Re: CPA boot crash (was: [PATCH] [0/36] Great change_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080118160757.GA24507@elte.hu>
Date:	Fri, 18 Jan 2008 17:07:57 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Andi Kleen <ak@...e.de>
Cc:	linux-kernel@...r.kernel.org, tglx@...utronix.de,
	jbeulich@...ell.com, venkatesh.pallipadi@...el.com
Subject: Re: CPA boot crash (was: [PATCH] [0/36] Great change_page_attr
	patch series v3)


* Andi Kleen <ak@...e.de> wrote:

> > could you please make your queue bisectable?
> 
> The idea was that you git revert the original patches I referenced and 
> then drop the undo patches since I reimplement all that in different 
> ways (except for the white space changes, but that can be redone once 
> everything settled down again). Then it will be bisectable.

and how does that again make things bisectable in the middle of the PAT 
queue? For example if i undo:

  Subject: x86: pat: cpa, 32-bit
  From: Venkatesh Pallipadi <venkatesh.pallipadi@...el.com>

in the PAT series, the rest of PAT wont apply. The proper approach is to 
do incremental updates to the existing codebase, i.e. truly base CPA 
ontop of PAT.

about whitespaces:

> (except for the white space changes, but that can be redone once 
> everything settled down again). Then it will be bisectable.

it's a revert barrier (within v2.6.25), so it would be nicer and more 
maintainable to integrate the whitespace changes into your patches, via 
the method i suggested. (it can even be scripted up)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/