[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080118182437.GA10167@redhat.com>
Date: Fri, 18 Jan 2008 13:24:37 -0500
From: Dave Jones <davej@...hat.com>
To: Ingo Molnar <mingo@...e.hu>
Cc: Yinghai Lu <Yinghai.Lu@....COM>, venkatesh.pallipadi@...el.com,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] X86: fix typo PAT to X86_PAT
On Fri, Jan 18, 2008 at 01:31:40PM +0100, Ingo Molnar wrote:
> * Yinghai Lu <Yinghai.Lu@....COM> wrote:
>
> > > thanks. But, i think we should rather do the following: if X86_PAT
> > > is eanbled then /proc/mtrr should be read-only. There's no problem
> > > _looking_ at MTRR contents, as long as we do not try to modify them.
> > > Hm?
> >
> > anyway
> >
> > depends on !PAT
> >
> > need to be removed.
> >
> > it seems when PAT is used, some code still touch MTRR.
>
> you mean modifies MTRRs? Which code is that? (besides the /proc/mtrr
> userspace API)
This exclusion is going to be a real pain in the ass for distro kernels.
It's impossible for example to build a kernel that will now support
the MTRR-alike registers on the AMD K6/early Cyrix etc and also
support PAT.
Additionally, given people tend to update their kernels a lot more often
than they update to a whole new version of X, it means until userspace
has caught up, we can't ship a kernel with PAT supported, or else
X gets a lot slower due to the missing mtrr support.
Dave
--
http://www.codemonkey.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists