linux-kernel - Re: [mm patch] i915: fix invalid opcode exception on cpus without clflush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080118023110.GA31386@phobos.i.cabal.ca>
Date:	Thu, 17 Jan 2008 21:31:10 -0500
From:	Kyle McMartin <kyle@...artin.ca>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Kyle McMartin <kyle@...artin.ca>, akpm@...ux-foundation.org,
	airlied@...ux.ie, linux-kernel@...r.kernel.org
Subject: Re: [mm patch] i915: fix invalid opcode exception on cpus without
	clflush

On Thu, Jan 17, 2008 at 09:03:17PM -0500, H. Peter Anvin wrote:
> The #ifdef is bogus.  If it's required, it should go into 
> asm-x86/required_features.h and then cpu_has_clflush is static; otherwise 
> it's just plain wrong.
>

I have no objection to making cpu_has_clflush constant on x86_64. The
point was to get rid of a needless test & branch on 64-bit, and making
it constant will have the same effect.

cheers, Kyle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/