lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 19 Jan 2008 15:08:17 +0100 From: Ingo Molnar <mingo@...e.hu> To: Jan Engelhardt <jengelh@...putergmbh.de> Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Thomas Gleixner <tglx@...utronix.de>, "H. Peter Anvin" <hpa@...or.com> Subject: Re: x86: remove casts * Jan Engelhardt <jengelh@...putergmbh.de> wrote: > On Jan 18 2008 11:45, Ingo Molnar wrote: > >* Jan Engelhardt <jengelh@...putergmbh.de> wrote: > > > >> This is against x86/mm. > > > >hm, it has checkpatch failures - > > All false positives. no, not "All false positives", the first checkpatch failure is a blatant ugliness that you introduced: ERROR: use tabs not spaces #137: FILE: arch/x86/kernel/microcode.c:248: +^I^I EXT_SIGNATURE_SIZE * i;$ because you converted a tab to a sequence of 10 spaces: - ext_sig = (struct extended_signature *)((void *)ext_header - + EXT_HEADER_SIZE + EXT_SIGNATURE_SIZE * i); + ext_sig = (void *)ext_header + EXT_HEADER_SIZE + + EXT_SIGNATURE_SIZE * i; <........> (the second checkpatch warning is a false positive.) and i applied your patch before i notified you, but apparently you couldnt be bothered to check. Please do not bother to send patches with such an attitude, it's just a waste of people's time. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists