lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 19 Jan 2008 15:08:17 +0100
From:	Ingo Molnar <>
To:	Jan Engelhardt <>
Cc:	Linux Kernel Mailing List <>,
	Thomas Gleixner <>,
	"H. Peter Anvin" <>
Subject: Re: x86: remove casts

* Jan Engelhardt <> wrote:

> On Jan 18 2008 11:45, Ingo Molnar wrote:
> >* Jan Engelhardt <> wrote:
> >
> >> This is against x86/mm.
> >
> >hm, it has checkpatch failures -
> All false positives.

no, not "All false positives", the first checkpatch failure is a blatant 
ugliness that you introduced:

 ERROR: use tabs not spaces
 #137: FILE: arch/x86/kernel/microcode.c:248:
 +^I^I          EXT_SIGNATURE_SIZE * i;$

because you converted a tab to a sequence of 10 spaces:

-		ext_sig = (struct extended_signature *)((void *)ext_header
+		ext_sig = (void *)ext_header + EXT_HEADER_SIZE +
+		          EXT_SIGNATURE_SIZE * i;

(the second checkpatch warning is a false positive.)

and i applied your patch before i notified you, but apparently you 
couldnt be bothered to check. Please do not bother to send patches with 
such an attitude, it's just a waste of people's time.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists