lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 19 Jan 2008 09:49:57 -0600 From: Matt Mackall <mpm@...enic.com> To: Miklos Szeredi <miklos@...redi.hu> Cc: riel@...hat.com, torvalds@...ux-foundation.org, ioe-lkml@...eria.de, peterz@...radead.org, salikhmetov@...il.com, linux-mm@...ck.org, jakob@...hought.net, linux-kernel@...r.kernel.org, valdis.kletnieks@...edu, ksm@...dk, staubach@...hat.com, jesper.juhl@...il.com, akpm@...ux-foundation.org, protasnb@...il.com, r.e.wolff@...wizard.nl, hidave.darkstar@...il.com, hch@...radead.org Subject: Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapped files On Sat, 2008-01-19 at 11:22 +0100, Miklos Szeredi wrote: > > Reminds me, I've got a patch here for addressing that problem with loop mounts: > > > > Writes to loop should update the mtime of the underlying file. > > > > Signed-off-by: Matt Mackall <mpm@...enic.com> > > > > Index: l/drivers/block/loop.c > > =================================================================== > > --- l.orig/drivers/block/loop.c 2007-11-05 17:50:07.000000000 -0600 > > +++ l/drivers/block/loop.c 2007-11-05 19:03:51.000000000 -0600 > > @@ -221,6 +221,7 @@ static int do_lo_send_aops(struct loop_d > > offset = pos & ((pgoff_t)PAGE_CACHE_SIZE - 1); > > bv_offs = bvec->bv_offset; > > len = bvec->bv_len; > > + file_update_time(file); > > while (len > 0) { > > sector_t IV; > > unsigned size; > > @@ -299,6 +300,7 @@ static int __do_lo_send_write(struct fil > > > > set_fs(get_ds()); > > bw = file->f_op->write(file, buf, len, &pos); > > + file_update_time(file); > > ->write should have already updated the times, no? Yes, this second case is redundant. Still needed in the first case. -- Mathematics is the supreme nostalgia of our time. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists