linux-kernel - [lguest build regression fix] Re: 2.6.24-rc8-git1: Reported regressions from 2.6.23

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080119180604.GA6224@elte.hu>
Date:	Sat, 19 Jan 2008 19:06:04 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Rusty Russell <rusty@...tcorp.com.au>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Adrian Bunk <bunk@...nel.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: [lguest build regression fix] Re: 2.6.24-rc8-git1: Reported
	regressions from 2.6.23


x86 randconfig testing found the following build failure:

 arch/x86/lguest/boot.c: In function 'lazy_hcall':
 arch/x86/lguest/boot.c:151: error: implicit declaration of function 'paravirt_get_lazy_mode'
 arch/x86/lguest/boot.c:151: error: 'PARAVIRT_LAZY_NONE' undeclared (first use in this function)

which i bisected down to this very fresh commit:

 commit 84f7466ee20cc094aa38617abfa2f3834871f054
 Author: Rusty Russell <rusty@...tcorp.com.au>
 Date:   Sat Jan 19 07:02:29 2008 +1100

     Selecting LGUEST should turn on Guest support, as in 2.6.23.

which allows the following .config variation:

 # CONFIG_PARAVIRT_GUEST is not set
 CONFIG_LGUEST_GUEST=y

please revert that commit, or apply the fix below.

btw., i didnt even notice that patch because it is not visible on lkml, 
etc.

NOTE: i found this problem this very minute so the patch below has not 
been tested through yet (it does build and boot with the attached 
config), but it seems obvious (to me).

	Ingo

------------------->
Subject: x86: lguest fix
From: Ingo Molnar <mingo@...e.hu>

this commit:

 commit 84f7466ee20cc094aa38617abfa2f3834871f054
 Author: Rusty Russell <rusty@...tcorp.com.au>
 Date:   Sat Jan 19 07:02:29 2008 +1100

      Selecting LGUEST should turn on Guest support, as in 2.6.23.

caused build failures due to allowing LGUEST to be selected without
paravirt support.

Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 drivers/lguest/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/drivers/lguest/Kconfig
===================================================================
--- linux.orig/drivers/lguest/Kconfig
+++ linux/drivers/lguest/Kconfig
@@ -1,6 +1,6 @@
 config LGUEST
 	tristate "Linux hypervisor example code"
-	depends on X86_32 && EXPERIMENTAL && !X86_PAE && FUTEX && !(X86_VISWS || X86_VOYAGER)
+	depends on X86_32 && EXPERIMENTAL && PARAVIRT_GUEST && !X86_PAE && FUTEX && !(X86_VISWS || X86_VOYAGER)
 	select HVC_DRIVER
 	select LGUEST_GUEST
 	---help---

View attachment "config" of type "text/plain" (48826 bytes)