linux-kernel - Re: [PATCH] Core driver for WM97xx touchscreens

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bc64b4640801191418m6b8197c8l498e181d267bb200@mail.gmail.com>
Date:	Sun, 20 Jan 2008 01:18:40 +0300
From:	Dmitry <dbaryshkov@...il.com>
To:	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	liam.girdwood@...fsonmicro.com
Subject: Re: [PATCH] Core driver for WM97xx touchscreens

Hi,

2008/1/20, Mark Brown <broonie@...nsource.wolfsonmicro.com>:
> On Sat, Jan 19, 2008 at 10:48:32PM +0300, Dmitry wrote:
>
> > Well... It's a common suggestion not to duplicate code. The wm97xx bus
> > looks mostly like platform. The only difference is the name. To help
> > visualisation, devices can have parents. Just set (in pseudocode)
> > wm97xx-touchscreen->parent to wm97xx, do the same for wm97xx-battery
> > and so on. Thus all devices would be on the platform device but with
> > proper parent <-> child notation.
>
> That's exactly what I had understood you to mean.  I guess it's just
> that using the platform bus for this purpose feels like an abstraction
> violation to me due to having platform devices parented off a device on
> another bus.  Obviously it's just my model of a platform device that's
> wrong here.  I will change the driver to use the platform bus for my
> next submission.

Hmm. I forgot about rooting this onto ac97 bus. But I would still suggest
using platform bus just for the sake of code clarity and simplicity.

>
> > git://git.mnementh.co.uk/linux-2.6-im.git#tmio_dev_try3. Look for
>
> Thanks, I'll take a look.
>
> > 2008/1/19, Mark Brown <broonie@...nsource.wolfsonmicro.com>:
>
> > > current patch series these chips all also provide an audio codec which
> > > requires a reasonably substantial driver for full support.
>
> > This would only touch child devices organisation.
>
> Indeed - I mention it mostly for additional motivation.
>


-- 
With best wishes
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/