| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1200733464.5724.166.camel@brick> Date: Sat, 19 Jan 2008 01:04:24 -0800 From: Harvey Harrison <harvey.harrison@...il.com> To: Ingo Molnar <mingo@...e.hu> Cc: "H. Peter Anvin" <hpa@...or.com>, LKML <linux-kernel@...r.kernel.org>, Andi Kleen <ak@...e.de>, Thomas Gleixner <tglx@...utronix.de> Subject: Re: [PATCH] x86: Unify printk strings in fault_32|64.c On Sat, 2008-01-19 at 09:13 +0100, Ingo Molnar wrote: > * Harvey Harrison <harvey.harrison@...il.com> wrote: > > > #ifdef CONFIG_X86_32 > > - "%s%s[%d]: segfault at %lx ip %08lx sp %08lx error %lx\n", > > + "%s%s[%d]: segfault at %lx ip %08lx sp %08lx error %lx", > > #else > > > #ifdef CONFIG_X86_32 > > - "%s%s[%d]: segfault at %08lx ip %08lx sp %08lx error %lx\n", > > + "%s%s[%d]: segfault at %lx ip %08lx sp %08lx error %lx", > > #else > > thanks, applied. > > Ingo I'm just looking at some of the other printks in do+page_fault right now in the oops code. What do you prefer: "Unable to handle kernel NULL pointer dereference" or "BUG: unable to handle kernel NULL pointer dereference" Other than that, I think for the most part, the shorter X86_64 strings are better. This does change user-visible output however, but would be nice to have a similar format. Harvey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists