linux-kernel - Re: [lguest build regression fix] Re: 2.6.24-rc8-git1: Reported regressions from 2.6.23

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200801201154.19118.rusty@rustcorp.com.au>
Date:	Sun, 20 Jan 2008 11:54:18 +1100
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: [lguest build regression fix] Re: 2.6.24-rc8-git1: Reported regressions from 2.6.23

On Sunday 20 January 2008 10:49:45 Adrian Bunk wrote:
> On Sun, Jan 20, 2008 at 10:24:47AM +1100, Rusty Russell wrote:
> > On Sunday 20 January 2008 05:06:04 Ingo Molnar wrote:
> > >  # CONFIG_PARAVIRT_GUEST is not set
> > >  CONFIG_LGUEST_GUEST=y
> >
> > This looks like a "randconfig" bug, to be honest.
>
> According to GNU grep we have two CONFIG_LGUEST_GUEST variables (sic),
> one in arch/x86/lguest/Kconfig and one in drivers/lguest/Kconfig.
>
> Rusty, don't blame randconfig for finding bugs in this mess you
> created...

My apologies, it is my mess.  The one in drivers/lguest/Kconfig is the old
(bogus) one: looks like I lost the removal part in a patch merge back in
September.

I've tested this patch.  It correctly handles Ingo's config (removes lguest
guest support).  Both lguest and lguest guest support can be turned on
independently, and it still compiles.

How embarrassing,
Rusty.
---
Remove bogus duplicate CONFIG_LGUEST_GUEST entry.

It was moved to arch/x86/lguest/Kconfig, but I lost the deletion part in a
patch suffle.  My confused one-liner "fix" to turn it on is also reverted:
84f7466ee20cc094aa38617abfa2f3834871f054

Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>

diff -r 3db2cadc1a30 drivers/lguest/Kconfig
--- a/drivers/lguest/Kconfig	Sun Jan 20 11:25:15 2008 +1100
+++ b/drivers/lguest/Kconfig	Sun Jan 20 11:47:57 2008 +1100
@@ -2,7 +2,6 @@ config LGUEST
 	tristate "Linux hypervisor example code"
 	depends on X86_32 && EXPERIMENTAL && !X86_PAE && FUTEX && !(X86_VISWS || X86_VOYAGER)
 	select HVC_DRIVER
-	select LGUEST_GUEST
 	---help---
 	  This is a very simple module which allows you to run
 	  multiple instances of the same Linux kernel, using the
@@ -11,9 +10,3 @@ config LGUEST
 	  not "rustyvisor".  See Documentation/lguest/lguest.txt.
 
 	  If unsure, say N.  If curious, say M.  If masochistic, say Y.
-
-config LGUEST_GUEST
-	bool
-	help
-	  The guest needs code built-in, even if the host has lguest
-	  support as a module.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/