[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200801211138.38591.rusty@rustcorp.com.au>
Date: Mon, 21 Jan 2008 11:38:38 +1100
From: Rusty Russell <rusty@...tcorp.com.au>
To: Sam Ravnborg <sam@...nborg.org>
Cc: Randy Dunlap <randy.dunlap@...cle.com>,
lkml <linux-kernel@...r.kernel.org>, dipankar@...ibm.com,
akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH] rcu: fix section mismatch
On Sunday 20 January 2008 08:25:49 Sam Ravnborg wrote:
> On Sat, Jan 19, 2008 at 11:56:43AM -0800, Randy Dunlap wrote:
> > rcu_online_cpu() should be __cpuinit instead of __devinit.
>
> So if we have:
> CONFIG_HOTPLUG=n
> CONFIG_HOTPLUG_CPU=y
>
> then this is a oops candidate.
At first glance, this can't happen because all CONFIG_HOTPLUG_CPU depends on
CONFIG_HOTPLUG or selects it, for all archs.
But CONFIG_PM_SLEEP_SMP selects CONFIG_HOTPLUG_CPU, without requiring
CONFIG_HOTPLUG: turning on SUSPEND or HIBERNATION does this.
Perhaps it's time to revisit reverse-depends for select?
Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists