linux-kernel - Re: [PATCH] pata_pdc202xx_old: Fix crashes with ATAPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200801220225.10168.bzolnier@gmail.com>
Date:	Tue, 22 Jan 2008 02:25:10 +0100
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	jeff@...zik.org, akpm@...l.org, torvalds@...l.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pata_pdc202xx_old: Fix crashes with ATAPI

On Tuesday 22 January 2008, Alan Cox wrote:
> > IDE pdc202xx_old host driver supports ATAPI DMA just fine and in line
> > with the PDC2026x programming guide.
> 
> News to me. It didn't last time I tried it the driver selected PIO.

Hmmm...

commit f3d5b34caae393f13a9486036f98c81cac1595c4
Author: Tobias Oed <tobiasoed@...mail.com>
Date:   Tue Oct 3 01:14:17 2006 -0700

    [PATCH] Enable cdrom dma access with pdc20265_old

    This patch allows me to use dma with my cd/dvd attached to my on board
    pdc20265 ide controller
...
    Acked-by: Alan Cox <alan@...rguk.ukuu.org.uk>
    Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@...a.pw.edu.pl>
...

Are you by any chance using PDC20263?

[ PDC2026{5,7} should be fine (unless somebody broke it but then git-bisect
  should do the job)... ]

> > > So turn it ATAPI DMA off, these are disk optimised controllers.
> > 
> > This is an acceptable workaround for 2.6.24 but it probably just hides
> > some deeper pata_pdc202xx_old or/and libata problem.
> 
> Hard to be sure. No docs here for the older ones.

I lack the docs for PDC20263...

Bart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/