linux-kernel - Re: [PATCH 05/26] atl1: print debug info if rrd error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4795BD93.8070303@garzik.org>
Date:	Tue, 22 Jan 2008 04:55:31 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	jacliburn@...lsouth.net
CC:	csnook@...hat.com, linux-kernel@...r.kernel.org,
	atl1-devel@...ts.sourceforge.net
Subject: Re: [PATCH 05/26] atl1: print debug info if rrd error

jacliburn@...lsouth.net wrote:
> From: Jay Cliburn <jacliburn@...lsouth.net>
> 
> Add some debug dev_printks if we encounter a bad receive return descriptor.
> 
> Signed-off-by: Jay Cliburn <jacliburn@...lsouth.net>
> ---
>  drivers/net/atlx/atl1.c |   21 ++++++++++++++++++++-
>  1 files changed, 20 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c
> index 239641f..262d3ca 100644
> --- a/drivers/net/atlx/atl1.c
> +++ b/drivers/net/atlx/atl1.c
> @@ -1127,7 +1127,26 @@ static void atl1_intr_rx(struct atl1_adapter *adapter)
>  		if (likely(rrd->xsz.valid)) {	/* packet valid */
>  chk_rrd:
>  			/* check rrd status */
> -			if (likely(rrd->num_buf == 1))
> +			if (rrd->num_buf != 1) {
> +				dev_printk(KERN_DEBUG, &adapter->pdev->dev,
> +					"rx_buf_len = %d\n",
> +					adapter->rx_buffer_len);
> +				dev_printk(KERN_DEBUG, &adapter->pdev->dev,
> +					"RRD num_buf = %d\n",
> +					rrd->num_buf);
> +				dev_printk(KERN_DEBUG, &adapter->pdev->dev,
> +					"RRD pkt_len = %d\n",
> +					rrd->xsz.xsum_sz.pkt_size);
> +				dev_printk(KERN_DEBUG, &adapter->pdev->dev,
> +					"RRD pkt_flg = 0x%08X\n",
> +					rrd->pkt_flg);
> +				dev_printk(KERN_DEBUG, &adapter->pdev->dev,
> +					"RRD err_flg = 0x%08X\n",
> +					rrd->err_flg);
> +				dev_printk(KERN_DEBUG, &adapter->pdev->dev,
> +					"RRD vlan_tag = 0x%08X\n",
> +					rrd->vlan_tag);
> +			} else

look into netif_msg_*, which enables via ethtool very fine-grained 
selection of messages.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/