linux-kernel - Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interrupts disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.58.0801231315500.6127@gandalf.stny.rr.com>
Date:	Wed, 23 Jan 2008 13:18:19 -0500 (EST)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Daniel Walker <dwalker@...sta.com>
cc:	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Christoph Hellwig <hch@...radead.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>,
	Gregory Haskins <ghaskins@...ell.com>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	Tim Bird <tim.bird@...sony.com>,
	Sam Ravnborg <sam@...nborg.org>,
	"Frank Ch. Eigler" <fche@...hat.com>,
	Jan Kiszka <jan.kiszka@...mens.com>,
	John Stultz <johnstul@...ibm.com>,
	Arjan van de Ven <arjan@...radead.org>,
	Steven Rostedt <srostedt@...hat.com>
Subject: Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interrupts
 disabled


On Wed, 23 Jan 2008, Daniel Walker wrote:

>
> > 	if (wake_klogd && !runqueue_is_locked())
> > 		wake_up_klogd();
> >
> > This probably is the cleanest solution since it simply prevents the
> > deadlock from occurring.
>
> Do you really need to call it with the runqueue lock held .. There are
> other issue with the calls at that level.. For instance in -rt these
> call can actually hang the system in the console laying from inside
> printk (something I reported more than 6 months ago) .. It would be
> better to move them around the scheduler rather than inside it..

The wakeup hook in schedule is when we find out that we hit our max. I
could postpone that somehow, but that would require more glue code than I
would like to add.

As for -rt, we've disabled printk for consoles not ATOMIC safe. So the
only consoles that will print in atomic sections so far are, earlyprintk
and the VGA.

Tim, could you send me your "postponed print" patches. That sounds like
something the -rt patch could use.

Thanks,

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/