linux-kernel - Re: x86: GEODE fix MFGPT input clock value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080123223830.GA26219@cosmic.amd.com>
Date:	Wed, 23 Jan 2008 15:38:30 -0700
From:	"Jordan Crouse" <jordan.crouse@....com>
To:	"Willy Tarreau" <w@....eu>
cc:	"H. Peter Anvin" <hpa@...or.com>, "Ingo Molnar" <mingo@...e.hu>,
	"Arnd Hannemann" <hannemann@...informatik.rwth-aachen.de>,
	"Lars Heete" <hel@...in.de>,
	"Andres Salomon" <dilinger@...ued.net>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Linus Torvalds" <torvalds@...ux-foundation.org>
Subject: Re: x86: GEODE fix MFGPT input clock value

On 23/01/08 23:11 +0100, Willy Tarreau wrote:
> Hi Peter,
> 
> On Wed, Jan 23, 2008 at 01:59:32PM -0800, H. Peter Anvin wrote:
> > Willy Tarreau wrote:
> > >The GEODE MFGPT code assumed that 32kHz was 32000 Hz while the boards
> > >run on a 32.768 kHz digital watch crystal. In practise, it will not
> > >change the timer's frequency as the skew was only 2.4%, but it
> > >should provide more accurate intervals.
> > >- *  Divisor   Hz      Min Delta (S) Max Delta (S)
> > 
> > Seconds are "s", not "S" (S = siemens.)
> 
> You're quite right. Same as we should write kHz and not Khz. But I'm
> used to change other people's work and particularly comments the least
> possible. Do you want an update ?

Please do - I don't mind if you change the comments - better that they
are right.

Jordan

-- 
Jordan Crouse
Systems Software Development Engineer 
Advanced Micro Devices, Inc.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/