linux-kernel - Re: [PATCH] kernel/params.c: fix the module name length in param_sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200801231254.26918.rusty@rustcorp.com.au>
Date:	Wed, 23 Jan 2008 12:54:26 +1100
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Jan Engelhardt <jengelh@...putergmbh.de>
Cc:	Denis Cheng <crquan@...il.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Dave Young <hidave.darkstar@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel/params.c: fix the module name length in param_sysfs_builtin

On Wednesday 23 January 2008 10:13:37 Jan Engelhardt wrote:
> On Jan 21 2008 22:16, Rusty Russell wrote:
> >On Monday 21 January 2008 20:08:25 Denis Cheng wrote:
> >> the original code use KOBJ_NAME_LEN for built-in module name length,
> >> that's defined to 20 in linux/kobject.h, but this is not enough
> >> appearntly, many module names are longer than this;
> >>  #define KOBJ_NAME_LEN                   20
> >
> >Thanks, applied.  I was surprisedto learn that we have a 35-char source
> >filename in the kernel.
> >
> >And congratulations to nf_conntrack_l3proto_ipv4_compat.c!
>
> But nf..dada_compat.c gets linked into nf_conntrack_ipv4.ko,
> and that is what is used in /sys/module - and it fits the 20.
> Any place where nf_conntrack_l3proto_ipv4_compat would still be used?

Of course, but my point was that we already have a 35 char filename in the 
kernel, and lots of > 22 chars, so increasing it is not unreasonable.

FYI make allmodconfig here gives me the following of 21 chars or longer:

dvb-usb-af9005-remote
dvb-usb-dibusb-common
nf_conntrack_netbios_ns
nf_conntrack_proto_udplite
nf_conntrack_proto_sctp
nf_conntrack_proto_gre

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/