[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4798B724.8050208@redhat.com>
Date: Thu, 24 Jan 2008 11:04:52 -0500
From: Jarod Wilson <jwilson@...hat.com>
To: Stefan Richter <stefanr@...6.in-berlin.de>
CC: linux1394-devel@...ts.sourceforge.net,
linux-kernel@...r.kernel.org,
Kristian Høgsberg <krh@...hat.com>,
Nick Piggin <nickpiggin@...oo.com.au>
Subject: Re: [PATCH 1/4] firewire: fw-sbp2: use device generation, not card
generation
Stefan Richter wrote:
> There was a small window where a login or reconnect job could use an
> already updated card generation with an outdated node ID. We have to
> use the fw_device.generation here, not the fw_card.generation, because
> the generation must never be newer than the node ID when we emit a
> transaction. This cannot be guaranteed with fw_card.generation.
>
> Furthermore, the target's and initiator's node IDs can be obtained from
> fw_device and fw_card. Dereferencing their underlying topology objects
> is not necessary.
>
> Signed-off-by: Stefan Richter <stefanr@...6.in-berlin.de>
Verified in concert with parts 2 and 3 as well as with 2, 3 and 4, to fix
'giving up on config rom' issues on multiple system and drive combinations
that were previously affected.
Signed-off-by: Jarod Wilson <jwilson@...hat.com>
--
Jarod Wilson
jwilson@...hat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists