[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080123191704.2d74073a@zod.rchland.ibm.com>
Date: Wed, 23 Jan 2008 19:17:04 -0600
From: Josh Boyer <jwboyer@...ux.vnet.ibm.com>
To: Roel Kluin <12o3l@...cali.nl>
Cc: lkml <linux-kernel@...r.kernel.org>, linuxppc-dev@...abs.org,
sr@...x.de
Subject: Re: [PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c
On Wed, 23 Jan 2008 23:37:33 +0100
Roel Kluin <12o3l@...cali.nl> wrote:
> logical/bitand typo
>
> Signed-off-by: Roel Kluin <12o3l@...cali.nl>
> ---
> diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c
> index ebf9e21..dcfb459 100644
> --- a/arch/powerpc/boot/4xx.c
> +++ b/arch/powerpc/boot/4xx.c
> @@ -104,7 +104,7 @@ void ibm4xx_denali_fixup_memsize(void)
> val = DDR_GET_VAL(val, DDR_CS_MAP, DDR_CS_MAP_SHIFT);
> cs = 0;
> while (val) {
> - if (val && 0x1)
> + if (val & 0x1)
> cs++;
> val = val >> 1;
> }
Hm, good catch.
Stefan, have you had problems with this code at all?
josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists