lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 24 Jan 2008 18:50:33 +0100 From: Pavel Machek <pavel@....cz> To: Dave Hansen <haveblue@...ibm.com> Cc: Cedric Le Goater <clg@...ibm.com>, Linux Containers <containers@...ts.osdl.org>, Andrew Morton <akpm@...ux-foundation.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Pavel Emelyanov <xemul@...nvz.org> Subject: Re: [PATCH 1/2] Extend sys_clone and sys_unshare system calls API On Thu 2008-01-24 09:46:57, Dave Hansen wrote: > On Thu, 2008-01-24 at 18:37 +0100, Pavel Machek wrote: > > > Did we decide not to do something with a variable number of > > arguments? > > > > > > sys_clonefoo(unsigned long *flags, int len); > > > > That is evil, because that means strace can no longer reliably print > > flags being used (for example). > > Ahhh. Just like it can't print strings for "buf"? > > write(int fd, char *buf, size_t len) > > Man, strace is stupid! ;) I said _reliably_. Guess what happens on smp when one process will periodically overwrite buf, and second will do the syscall? It sucks for write, but it would suck much more for clone, where flags drastically change the behaviour. (Yep, it is possible to do reliably, see subterfugue, but it is a lot of work and lot of overhead). > If that's *really* a concern, why don't we just pass, say 4 or 5 longs > in: > > sys_clonebig(unsigned long flags0, unsigned long flags1, > unsigned long flags2, unsigned long flags3); Works for me. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists