linux-kernel - Re: [PATCH] Missing usb_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080124180313.GA16006@kroah.com>
Date:	Thu, 24 Jan 2008 10:03:13 -0800
From:	Greg KH <greg@...ah.com>
To:	Pekka Enberg <penberg@...helsinki.fi>
Cc:	Wilco Beekhuizen <wilcobeekhuizen@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Missing usb_find_device symbol from usb.c

On Thu, Jan 24, 2008 at 07:42:20PM +0200, Pekka Enberg wrote:
> Hi Greg,
> 
> On Jan 24, 2008 7:20 PM, Greg KH <greg@...ah.com> wrote:
> > > So it's not a simple code change at all.
> >
> > Just create a root directory for every device that is seen in the
> > probe() function.  That should be pretty simple to do.
> 
> Yeah, that would work but why do we want to mount all devices under
> the same mount point? If you move device discovery to ->probe() it's
> simple to have per-device mount points by overriding ->get_sb() to
> check for USB_DEVICE_MAJOR and look up the actual device, no?
> Otherwise you have to deal with device plug/unplug at filesystem
> level...

Yes, you could do that (per device mount), but it might be confusing for
users to have to control things that way.

And the unplug issue at a filesystem level should be pretty trivial to
handle, we do it all the time in /proc and /sys and other virtual
filesystems (usbfs) with no problems.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/