linux-kernel - Re: [PATCH 23/27] NFS: Fix memory leak [try #2]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1201209329.7054.41.camel@heimdal.trondhjem.org>
Date:	Thu, 24 Jan 2008 16:15:29 -0500
From:	Trond Myklebust <Trond.Myklebust@...app.com>
To:	David Howells <dhowells@...hat.com>
Cc:	nfsv4@...ux-nfs.org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, selinux@...ho.nsa.gov,
	linux-security-module@...r.kernel.org
Subject: Re: [PATCH 23/27] NFS: Fix memory leak [try #2]


On Wed, 2008-01-23 at 17:22 +0000, David Howells wrote:
> Fix a memory leak whereby multiple clientaddr=xxx mount options just overwrite
> the duplicated client_address option pointer, without freeing the old memory.
> 
> Signed-off-by: David Howells <dhowells@...hat.com>
> ---
> 
>  fs/nfs/super.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> 
> diff --git a/fs/nfs/super.c b/fs/nfs/super.c
> index 0b0c72a..7f5e747 100644
> --- a/fs/nfs/super.c
> +++ b/fs/nfs/super.c
> @@ -936,6 +936,7 @@ static int nfs_parse_mount_options(char *raw,
>  			string = match_strdup(args);
>  			if (string == NULL)
>  				goto out_nomem;
> +			kfree(mnt->client_address);
>  			mnt->client_address = string;
>  			break;
>  		case Opt_mountaddr:

Thanks. This fix has already been applied to the NFS git tree.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/