lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20080124140913.5FFE.Y-GOTO@jp.fujitsu.com>
Date:	Thu, 24 Jan 2008 14:20:05 +0900
From:	Yasunori Goto <y-goto@...fujitsu.com>
To:	rossb@...gle.com (Ross Biro), rossb@...gle.com
Cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [RFC][PATCH 1/2]: MM: Make Paget Tables Relocatable--Conditional  TLB Flush


Hello.

This is a nitpick, but all of archtectures code except generic use
MMF_NNED_FLUSH at clear_bit()...
     ^
Please fix misspell.

Bye.

> 
> diff -uprwNbB -X 2.6.23/Documentation/dontdiff 2.6.23/arch/alpha/kernel/smp.c 2.6.23a/arch/alpha/kernel/smp.c
> --- 2.6.23/arch/alpha/kernel/smp.c	2007-10-09 13:31:38.000000000 -0700
> +++ 2.6.23a/arch/alpha/kernel/smp.c	2007-10-29 13:50:06.000000000 -0700
> @@ -850,6 +850,8 @@ flush_tlb_mm(struct mm_struct *mm)
>  {
>  	preempt_disable();
>  
> +	clear_bit(MMF_NNED_FLUSH, mm->flags);
> +
>  	if (mm == current->active_mm) {
>  		flush_tlb_current(mm);
>  		if (atomic_read(&mm->mm_users) <= 1) {


-- 
Yasunori Goto 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ