linux-kernel - Re: [PATCH 076/196] ecryptfs: remove version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47999CF2.9070805@garzik.org>
Date:	Fri, 25 Jan 2008 03:25:22 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Greg Kroah-Hartman <gregkh@...e.de>
CC:	linux-kernel@...r.kernel.org, Kay Sievers <kay.sievers@...y.org>,
	Mike Halcrow <mhalcrow@...ibm.com>,
	Phillip Hellewell <phillip@...lewell.homeip.net>
Subject: Re: [PATCH 076/196] ecryptfs: remove version_str file from sysfs

Greg Kroah-Hartman wrote:
> This file violates the one-value-per-file sysfs rule.
> 
> If you all want it added back, please do something like a per-feature
> file to show what is present and what isn't.
> 
> Cc: Kay Sievers <kay.sievers@...y.org>
> Cc: Mike Halcrow <mhalcrow@...ibm.com>
> Cc: Phillip Hellewell <phillip@...lewell.homeip.net>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> ---
>  fs/ecryptfs/main.c |   43 -------------------------------------------
>  1 files changed, 0 insertions(+), 43 deletions(-)

It's not really good policy to rip out ABIs found in release kernels 
like this, even if the motivation is sound.

IMO "don't break ABIs" rule is far more important than a 
one-value-per-file sysfs rule.

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/