linux-kernel - Re: [patch 01/26] mount options: add documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1JILOa-0001Ru-MN@pomaz-ex.szeredi.hu>
Date:	Fri, 25 Jan 2008 11:02:48 +0100
From:	Miklos Szeredi <miklos@...redi.hu>
To:	ezk@...sunysb.edu
CC:	miklos@...redi.hu, akpm@...ux-foundation.org,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	sfrench@...ibm.com, lachlan@....com, jsipek@...sunysb.edu,
	rmk@....linux.org.uk, zippel@...ux-m68k.org, dhowells@...hat.com,
	raven@...maw.net, rathamahata@...4.ru, kkeil@...e.de,
	hpa@...or.com, tytso@....edu, hirofumi@...l.parknet.co.jp,
	jdike@...toit.com, mikulas@...ax.karlin.mff.cuni.cz,
	wli@...omorphy.com, shaggy@...tin.ibm.com, vandrove@...cvut.cz,
	Trond.Myklebust@...app.com, jeffm@...e.com, paulus@...ba.org,
	hugh@...itas.com, gorcunov@...il.com, gregkh@...e.de
Subject: Re: [patch 01/26] mount options: add documentation

> Where did you check for the existence of a ->show_options method for
> unionfs?  Unionfs does implement ->show_options and supports all of the
> mount/remount options.  See:
> 
> <http://git.kernel.org/?p=linux/kernel/git/ezk/unionfs.git;a=blob;f=fs/unionfs/super.c;h=986c980261a5b171147d66ac05bf08423e2fd6b6;hb=HEAD#l963>
> 
> The unionfs ->remount code supports branch-management options which can
> add/del/change a branch, but we don't show those directly in ->show_options;
> it makes more sense to show the final (and thus most current) branch
> configuration.
> 
> Could you update your records please?

Sure.  Sorry about that, I did actually look at unionfs, and it was
just an administration error and bad memory (in my head).

> BTW, I should be able to use your save_mount_options().

It is probably better not to use save_mount_options().  Especially,
since unionfs implemets a remount, that changes the tree only
partially AFAICS.

Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/