linux-kernel - Re: [PATCH 5/9] bfs: move function prototype to the proper header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4799C42C.7030501@gmail.com>
Date:	Fri, 25 Jan 2008 14:12:44 +0300
From:	Dmitri Vorobiev <dmitri.vorobiev@...il.com>
To:	Adrian Bunk <bunk@...nel.org>
CC:	Tigran Aivazian <tigran@...azian.fsnet.co.uk>,
	Heikki Orsila <shdl@...alwe.fi>, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, trivial@...nel.org
Subject: Re: [PATCH 5/9] bfs: move function prototype to the proper header
 file

Adrian Bunk пишет:
> On Thu, Jan 24, 2008 at 11:22:21PM +0000, Tigran Aivazian wrote:
>> On Fri, 25 Jan 2008, Dmitri Vorobiev wrote:
>>
>>> Heikki Orsila пишет:
>>>>> +extern void dump_imap(const char *, struct super_block *);
>>>>> +
>>>> Functions should not be externed, remove extern keyword.
>>>>
>>> Care to explain why?
>> because dump_imap() is just a BFS' internal helper (for debugging 
>> purposes only btw) to dump the inode map via printk. Why should it be 
>> moved into the header, i.e. where one expects to see things potentially 
>> visible by the rest of the kernel?
>> ...
> 
> fs/bfs/bfs.h is not visible to the rest of the kernel, it's the right 
> place for bfs-internal code.
> 
> Whether there's an "extern" written is just a syntax thing with zero 
> semantical implications. We tend to not write the "extern" in the 
> kernel, but that's nothing cast in stone.

Adrian, thanks for the feedback.

The next version of this patch series will not have the extern keyword
for this helper. I'll try to have the second version sent to trivial
by tomorrow.

Dmitri

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/