linux-kernel - Re: [PATCH] [NET]: Remove PowerPC code from fec.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <479A087F.5010305@scram.de>
Date:	Fri, 25 Jan 2008 17:04:15 +0100
From:	Jochen Friedrich <jochen@...am.de>
To:	Frans Pop <elendil@...net.nl>
CC:	galak@...nel.crashing.org, geert@...ux-m68k.org, gerg@...inux.org,
	jgarzik@...ox.com, linux-kernel@...r.kernel.org,
	linux-m68k@...r.kernel.org, linuxppc-dev@...abs.org,
	netdev@...r.kernel.org, scottwood@...escale.com,
	vitb@...nel.crashing.org
Subject: Re: [PATCH] [NET]: Remove PowerPC code from fec.c

Hi Frans,

> Jochen Friedrich wrote:
>> +++ b/drivers/net/fec.c
>> @@ -23,6 +23,9 @@
>>   *
>>   * Bug fixes and cleanup by Philippe De Muyter (phdm@...qel.be)
>>   * Copyright (c) 2004-2006 Macq Electronique SA.
>> + *
>> + * This driver is now only used on ColdFire processors. Remove conditional
>> + * Powerpc code. 
>>   */
> 
> This comment makes sense for a changelog, but IMO it makes no sense at all
> to add it to the file.

I just added it to clarify this code is now only used on m68knommu (Coldfire).
The comments on top are mailny about MPC860T CPUs (PowerPC), however the driver is no
longer used for these CPUs.

Maybe the wording should be changed to:

This driver is now only used on ColdFire (m68knommu) processors. Conditional
PowerPC code has been removed.

Thanks,
Jochen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/