linux-kernel - Re: [PATCH] 2.4: fix memory corruption from misinterpreted bad_inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080125045320.GA24179@1wt.eu>
Date:	Fri, 25 Jan 2008 05:53:21 +0100
From:	Willy Tarreau <w@....eu>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	dann frazier <dannf@...nf.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] 2.4: fix memory corruption from misinterpreted	bad_inode_ops return values

On Thu, Jan 24, 2008 at 04:48:10PM -0600, Eric Sandeen wrote:
> dann frazier wrote:
> 
> > Thanks Eric. Sounds like my comment about exercising these code paths
> > wasn't too clear - the comments with your patch do make the issue
> > clear, and this program demonstrates the void cast promotion issue
> > well. I'm just not sure of a good way to demonstrate that my backport
> > of this patch doesn't break anything for 2.4.
> 
> Ugh, no, that was my fault, I blindly copied & pasted something from a
> bug which I thought was a testcase, but isn't.  Sorry!
> 
> I originally saw this problem on an fsfuzzed filesystem; I don't think I
> still have that image around, though.

OK, that doesn't matter that much. At least the patch makes sense and
your example shows why original code is wrong, so I will merge it. If
anybody had a problem with it, the code would be easily bisectable
(there are so few patches in 2.4) and it's easy to revert it.

Thanks to you both, Eric and Dann !
Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/