linux-kernel - Re: [Linux-fbdev-devel] [PATCH] fbdev: make the best-fit section of fb_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080127132510.b00017cb.krzysztof.h1@poczta.fm>
Date:	Sun, 27 Jan 2008 13:25:10 +0100
From:	Krzysztof Helt <krzysztof.h1@...zta.fm>
To:	spock@...too.org, linux-fbdev-devel@...ts.sourceforge.net
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [Linux-fbdev-devel] [PATCH] fbdev: make the best-fit section of
 fb_find_mode return the closest matching mode

On Sun, 27 Jan 2008 12:31:16 +0100
Michal Januszewski <spock@...too.org> wrote:

> From: Michal Januszewski <spock@...too.org>
> 
> Currently, if a perfect match in terms of resolution is not found,
> fb_find_mode() only looks for a best-fit mode among modes with a
> higher resolution than the one requested.  Thus, if the user
> requests a resolution higher than the largest supported one, they
> are dropped to the default mode (usually a low resolution one).
> 

> Change this behaviour so that the true closest match in terms
> of the city-block metric is returned.
> 

This may be not ideal solution in case there exist both lower and
higher matches. If given resolution is closer (even by few pixels)
to lower one, your method will choose the lower one.
It may be incorrect for e.g. picture viewer (the higher resolution
shows the whole picture with margins, the smaller one shows
rescaled or cut picture).

IMHO, the choice of higher resolution (if possible) should be
preferred. It is also closer to the old solution.

Kind regards,
Krzysztof


----------------------------------------------------------------------
Nadchodzi galaktyczna wojna!
Sprawdz >> http://link.interia.pl/f1ce0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/