linux-kernel - Re: [PATCH -mm 1/2] Basic PWM driver for AVR32 and AT91

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080127151620.1ea94383@siona>
Date:	Sun, 27 Jan 2008 15:16:20 +0100
From:	Haavard Skinnemoen <hskinnemoen@...el.com>
To:	David Brownell <david-b@...bell.net>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Andrew Victor <linux@...im.org.za>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Patrice Vilchez <patrice.vilchez@....atmel.com>,
	Richard Purdie <rpurdie@...ys.net>,
	linux-kernel@...r.kernel.org, kernel@...32linux.org
Subject: Re: [PATCH -mm 1/2] Basic PWM driver for AVR32 and AT91

On Thu, 24 Jan 2008 12:53:13 -0800
David Brownell <david-b@...bell.net> wrote:

> On Thursday 24 January 2008, Haavard Skinnemoen wrote:
> > +config ATMEL_PWM
> > +       tristate "Atmel AT32/AT91 PWM support"
> > +       depends on (AVR32 || AT91) && EXPERIMENTAL
> 
> There's probably no need for EXPERIMENTAL except in the
> limited sense of "young driver".  :)

Yeah, I don't think EXPERIMENTAL makes sense here. Either you need the
PWM or you don't.

> There's a bug there ... it should have used ARCH_AT91 instead
> of just AT91.  Or even ARCH_AT91SAM9263 || ARCH_AT91SAM9RL.

I've turned it into ARCH_AT91. I think listing the specific chips that
have it is a bit too much; it won't break if you enable it on a chip
that doesn't have it, it will just be useless. That's what defconfigs
are for, and we still want people that test allmodconfigs on e.g.
AT91RM9200 to report any breakage.

Patch below.

Haavard

diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 03c0c27..23a9231 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -15,7 +15,7 @@ if MISC_DEVICES
 
 config ATMEL_PWM
 	tristate "Atmel AT32/AT91 PWM support"
-	depends on (AVR32 || AT91) && EXPERIMENTAL
+	depends on AVR32 || ARCH_AT91
 	help
 	  This option enables device driver support for the PWM channels
 	  on certain Atmel prcoessors.  Pulse Width Modulation is used for
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/