[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200801272041.52818.bzolnier@gmail.com>
Date: Sun, 27 Jan 2008 20:41:52 +0100
From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To: Borislav Petkov <petkovbb@...glemail.com>
Cc: linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org,
Borislav Petkov <bbpetkov@...oo.de>
Subject: Re: [PATCH 24/32] ide-tape: remove unreachable code chunk
On Sunday 27 January 2008, Borislav Petkov wrote:
> From: Borislav Petkov <bbpetkov@...oo.de>
>
> tape->speed_ctl is set to 1 in idetape_setup(), but, in calculate_speeds() its
> value is tested for being 0, 1, or 2. Remove the if-branches where
> tape->speed_ctl != 1 since they are never executed.
>
> Also, rename calculate_speeds() by adding driver's prefix as is with the other
> function names.
>
> Signed-off-by: Borislav Petkov <bbpetkov@...oo.de>
This change is fine but it seems to depend on "ghost" patch #23. ;)
Please move it near the beginning of the series when resubmitting.
Thanks,
Bart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists